Skip to content

Add no-floating-promises options to tslint in order to ensure all promises are properly handled #3762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2018
Merged

Add no-floating-promises options to tslint in order to ensure all promises are properly handled #3762

merged 1 commit into from
Aug 30, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jul 20, 2018 •
edited
Loading

PR Checklist

What is the current behavior?

grunt lint command does not print an error in case some await is missing

What is the new behavior?

grunt lint command prints an error in case some await is missing

DimitarTachev
DimitarTachev approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@DimitarTachev DimitarTachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Fatme Fatme added this to the 4.2.1 milestone Jul 23, 2018
@rosen-vladimirov rosen-vladimirov modified the milestones: 4.2.1, 4.2.2 Aug 7, 2018
@Fatme Fatme modified the milestones: 4.2.2, 4.2.3 Aug 15, 2018
@Fatme Fatme force-pushed the fatme/no-floating-promises branch from f1c42aa to 974d665 Compare August 29, 2018 12:50
@Fatme Fatme force-pushed the fatme/no-floating-promises branch from 974d665 to f25bccb Compare August 29, 2018 12:55
@Fatme Fatme modified the milestones: 4.2.3, 5.0.0 Aug 29, 2018
@Fatme
Copy link
Contributor Author

Fatme commented Aug 30, 2018

run ci

2 similar comments
@Fatme
Copy link
Contributor Author

Fatme commented Aug 30, 2018

run ci

@miroslavaivanova
Copy link
Contributor

run ci

@Fatme Fatme merged commit 049ccab into master Aug 30, 2018
@Fatme Fatme deleted the fatme/no-floating-promises branch August 30, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitarTachev DimitarTachev DimitarTachev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Fatme @miroslavaivanova @DimitarTachev @rosen-vladimirov